Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fileitem factory #362

Merged
merged 13 commits into from
Oct 14, 2024
Merged

Feature/fileitem factory #362

merged 13 commits into from
Oct 14, 2024

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented Sep 17, 2024

Replaces #360.

@Toflar Toflar added this to the 2.1 milestone Sep 17, 2024
config/services.php Outdated Show resolved Hide resolved
@Toflar Toflar marked this pull request as ready for review September 19, 2024 12:08
@Toflar
Copy link
Member Author

Toflar commented Sep 19, 2024

Is that what you need @aschempp? If so, I'll merge this :)

Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for my notes :)

src/BulkyItem/FileItemFactory.php Show resolved Hide resolved
src/BulkyItem/FileItemFactory.php Show resolved Hide resolved
src/BulkyItem/FileItemFactory.php Show resolved Hide resolved
@Toflar Toflar merged commit dce6aa4 into 2.1 Oct 14, 2024
8 checks passed
@Toflar Toflar deleted the feature/fileitem-factory branch October 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants